From: Barry Naujok <bnaujok@sgi.com>
Date: Thu, 20 Nov 2008 14:24:01 +0000 (+0000)
Subject: xfstests: fix buffer overflow in lstat64.c
X-Git-Tag: v1.1.0~349
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=39d66b52f36f3ecbd25b6eb1125abba8a01f6264;p=xfstests-dev.git

xfstests: fix buffer overflow in lstat64.c

lstat64.c was putting an 11-byte string into a 10-byte buffer.
Merge of master-melb:xfs-cmds:32512a by kenmcd.

  fix buffer overflow in lstat64.c
---

diff --git a/src/lstat64.c b/src/lstat64.c
index 12d1fe4e..59b92c50 100644
--- a/src/lstat64.c
+++ b/src/lstat64.c
@@ -57,7 +57,6 @@ int
 main(int argc, char **argv)
 {
 	struct stat64	sbuf;
-	char		mode[10];
 	int		i, c;
 	int		terse_flag = 0;
 
@@ -78,6 +77,7 @@ main(int argc, char **argv)
 	time(&timebuf);
 
 	for (i = optind; i < argc; i++) {
+		char *mode = "----------";
 
 		if( lstat64(argv[i], &sbuf) < 0) {
 			perror(argv[i]);
@@ -92,7 +92,6 @@ main(int argc, char **argv)
 			printf("  Size: %-10llu", (unsigned long long)sbuf.st_size);
 		}
 
-		strcpy(mode,"----------");
 		if (sbuf.st_mode & (S_IEXEC>>6))
 			mode[9] = 'x';
 		if (sbuf.st_mode & (S_IWRITE>>6))