From: Michal Jarzabek Date: Thu, 26 May 2016 17:10:46 +0000 (+0100) Subject: osd/OSD.h: add override to virtual functions X-Git-Tag: v11.0.0~292^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3a2a0b0659fb7b6f995e14ab56a7e6bb32ab2b28;p=ceph.git osd/OSD.h: add override to virtual functions Signed-off-by: Michal Jarzabek --- diff --git a/src/osd/OSD.h b/src/osd/OSD.h index 6fbebd6dc820..0721e30b2fda 100644 --- a/src/osd/OSD.h +++ b/src/osd/OSD.h @@ -1922,7 +1922,7 @@ private: : ThreadPool::BatchWorkQueue( "OSD::PeeringWQ", ti, si, tp), osd(o) {} - void _dequeue(PG *pg) { + void _dequeue(PG *pg) override { for (list::iterator i = peering_queue.begin(); i != peering_queue.end(); ) { @@ -1934,15 +1934,15 @@ private: } } } - bool _enqueue(PG *pg) { + bool _enqueue(PG *pg) override { pg->get("PeeringWQ"); peering_queue.push_back(pg); return true; } - bool _empty() { + bool _empty() override { return peering_queue.empty(); } - void _dequeue(list *out); + void _dequeue(list *out) override; void _process( const list &pgs, ThreadPool::TPHandle &handle) override { @@ -1953,14 +1953,14 @@ private: (*i)->put("PeeringWQ"); } } - void _process_finish(const list &pgs) { + void _process_finish(const list &pgs) override { for (list::const_iterator i = pgs.begin(); i != pgs.end(); ++i) { in_use.erase(*i); } } - void _clear() { + void _clear() override { assert(peering_queue.empty()); } } peering_wq; @@ -2284,17 +2284,17 @@ protected: CommandWQ(OSD *o, time_t ti, time_t si, ThreadPool *tp) : ThreadPool::WorkQueue("OSD::CommandWQ", ti, si, tp), osd(o) {} - bool _empty() { + bool _empty() override { return osd->command_queue.empty(); } - bool _enqueue(Command *c) { + bool _enqueue(Command *c) override { osd->command_queue.push_back(c); return true; } - void _dequeue(Command *pg) { + void _dequeue(Command *pg) override { assert(0); } - Command *_dequeue() { + Command *_dequeue() override { if (osd->command_queue.empty()) return NULL; Command *c = osd->command_queue.front(); @@ -2312,7 +2312,7 @@ protected: osd->osd_lock.Unlock(); delete c; } - void _clear() { + void _clear() override { while (!osd->command_queue.empty()) { Command *c = osd->command_queue.front(); osd->command_queue.pop_front(); @@ -2350,19 +2350,19 @@ protected: "OSD::RemoveWQ", ti, si, tp), store(o) {} - bool _empty() { + bool _empty() override { return remove_queue.empty(); } - void _enqueue(pair item) { + void _enqueue(pair item) override { remove_queue.push_back(item); } - void _enqueue_front(pair item) { + void _enqueue_front(pair item) override { remove_queue.push_front(item); } bool _dequeue(pair item) { assert(0); } - pair _dequeue() { + pair _dequeue() override { assert(!remove_queue.empty()); pair item = remove_queue.front(); remove_queue.pop_front(); @@ -2370,7 +2370,7 @@ protected: } void _process(pair, ThreadPool::TPHandle &) override; - void _clear() { + void _clear() override { remove_queue.clear(); } } remove_wq;