From: Samuel Just <sjust@redhat.com>
Date: Wed, 5 May 2021 05:22:18 +0000 (-0700)
Subject: seastore: add comment to do_transaction outlining ordering TODO
X-Git-Tag: v17.1.0~2043^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3a43a6e130998cc97c19b49946c22c98cdfcf15b;p=ceph.git

seastore: add comment to do_transaction outlining ordering TODO

Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/crimson/os/seastore/seastore.cc b/src/crimson/os/seastore/seastore.cc
index 191ca502ee42..ee0b79165871 100644
--- a/src/crimson/os/seastore/seastore.cc
+++ b/src/crimson/os/seastore/seastore.cc
@@ -556,6 +556,15 @@ seastar::future<> SeaStore::do_transaction(
   CollectionRef _ch,
   ceph::os::Transaction&& _t)
 {
+  /* TODO: add ordering to Collection
+   *
+   * TransactionManager::submit_transction will ensure that
+   * beginning at that point operations remain ordered through
+   * to the jorunal.  We still need a pipeline stage associated
+   * with each collection to ensure that this portion in
+   * SeaStore::do_transaction remains correctly ordered for operations
+   * submitted on the same collection. TODO
+   */
   return repeat_with_internal_context(
     _ch,
     std::move(_t),