From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Thu, 8 Jan 2015 11:35:33 +0000 (+0100)
Subject: TestErasureCodeIsa.cc: fix reassign before use old value
X-Git-Tag: suse_latest~36^2~9^2~22
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3cf04b8c70fe54ba157053cf6f0f7f1b59fdb1e0;p=ceph.git

TestErasureCodeIsa.cc: fix reassign before use old value

Fix for:

[src/test/erasure-code/TestErasureCodeIsa.cc:474] ->
 [src/test/erasure-code/TestErasureCodeIsa.cc:477]:
[src/test/erasure-code/TestErasureCodeIsa.cc:601] ->
 [src/test/erasure-code/TestErasureCodeIsa.cc:604]
[src/test/erasure-code/TestErasureCodeIsa.cc:728] ->
 [src/test/erasure-code/TestErasureCodeIsa.cc:731]
[src/test/erasure-code/TestErasureCodeIsa.cc:854] ->
 [src/test/erasure-code/TestErasureCodeIsa.cc:857]
 (performance) Variable 'err' is reassigned a value
 before the old one has been used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/test/erasure-code/TestErasureCodeIsa.cc b/src/test/erasure-code/TestErasureCodeIsa.cc
index b53a482f831..73fc5a5d094 100644
--- a/src/test/erasure-code/TestErasureCodeIsa.cc
+++ b/src/test/erasure-code/TestErasureCodeIsa.cc
@@ -471,7 +471,7 @@ TEST_F(IsaErasureCodeTest, isa_vandermonde_exhaustive)
   for (int l1 = 0; l1 < (k + m); l1++) {
     map<int, bufferlist> degraded = encoded;
     set<int> want_to_decode;
-    bool err = true;
+    bool err;
     degraded.erase(l1);
     want_to_decode.insert(l1);
     err = DecodeAndVerify(Isa, degraded, want_to_decode, enc, length);
@@ -598,7 +598,7 @@ TEST_F(IsaErasureCodeTest, isa_cauchy_exhaustive)
   for (int l1 = 0; l1 < (k + m); l1++) {
     map<int, bufferlist> degraded = encoded;
     set<int> want_to_decode;
-    bool err = true;
+    bool err;
     degraded.erase(l1);
     want_to_decode.insert(l1);
     err = DecodeAndVerify(Isa, degraded, want_to_decode, enc, length);
@@ -725,7 +725,7 @@ TEST_F(IsaErasureCodeTest, isa_cauchy_cache_trash)
   for (int l1 = 0; l1 < (k + m); l1++) {
     map<int, bufferlist> degraded = encoded;
     set<int> want_to_decode;
-    bool err = true;
+    bool err;
     degraded.erase(l1);
     want_to_decode.insert(l1);
     err = DecodeAndVerify(Isa, degraded, want_to_decode, enc, length);
@@ -851,7 +851,7 @@ TEST_F(IsaErasureCodeTest, isa_xor_codec)
   for (int l1 = 0; l1 < (k + m); l1++) {
     map<int, bufferlist> degraded = encoded;
     set<int> want_to_decode;
-    bool err = true;
+    bool err;
     degraded.erase(l1);
     want_to_decode.insert(l1);
     err = DecodeAndVerify(Isa, degraded, want_to_decode, enc, length);