From: Neha Ojha Date: Mon, 11 Nov 2019 21:32:15 +0000 (-0800) Subject: osd/OSDMap.cc: don't output over/underfull messages to lderr X-Git-Tag: v15.1.0~926^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=3cf28f09a2ebdd922fc5c1d29c65469f8331e741;p=ceph-ci.git osd/OSDMap.cc: don't output over/underfull messages to lderr There can be cases where overfull and underfull(see example in https://tracker.ceph.com/issues/42756) will be empty, which is not necessarily an error. These error messages can end up spamming the ceph-mgr log. Fixes: https://tracker.ceph.com/issues/42756 Signed-off-by: Neha Ojha --- diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc index 6b5930743a3..1cf0a463b2d 100644 --- a/src/osd/OSDMap.cc +++ b/src/osd/OSDMap.cc @@ -4623,7 +4623,7 @@ int OSDMap::calc_pg_upmaps( << dendl; } if (overfull.empty()) { - lderr(cct) << __func__ << " failed to build overfull" << dendl; + ldout(cct, 20) << __func__ << " failed to build overfull" << dendl; break; } @@ -4647,7 +4647,7 @@ int OSDMap::calc_pg_upmaps( << dendl; } if (underfull.empty()) { - lderr(cct) << __func__ << " failed to build underfull" << dendl; + ldout(cct, 20) << __func__ << " failed to build underfull" << dendl; break; }