From: Casey Bodley Date: Mon, 1 Dec 2025 15:25:16 +0000 (-0500) Subject: cmake: fix for -DWITH_BREAKPAD=OFF X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3d04c97d796e2ffe912ffc9017dfa83a3fbc604f;p=ceph.git cmake: fix for -DWITH_BREAKPAD=OFF in 1ba55a20be1023c585ba96617dc6a9d2aa79a51b, i tried to avoid the NOT condition by swapping the option's defaults. but when the condition is false, the option is forced to ON even if the user manually set it OFF fix this by inverting the condition and swapping the default values Reported-by: Joseph Mundackal Signed-off-by: Casey Bodley --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 42b8c383f57..546bbef96e3 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -540,8 +540,8 @@ endif() # enable breakpad unless win32 or power # ppc64le port tracked in https://issues.chromium.org/issues/41479970 -CMAKE_DEPENDENT_OPTION(WITH_BREAKPAD "Build with Google Breakpad crash reporter" OFF - "WIN32 OR CMAKE_SYSTEM_PROCESSOR MATCHES ppc64le" ON) +CMAKE_DEPENDENT_OPTION(WITH_BREAKPAD "Build with Google Breakpad crash reporter" ON + "NOT (WIN32 OR CMAKE_SYSTEM_PROCESSOR MATCHES ppc64le)" OFF) if(WITH_BREAKPAD) set(HAVE_BREAKPAD ON) message("-- Enabled Google Breakpad crash reporter")