From: Guillaume Abrioux Date: Tue, 26 May 2026 14:22:06 +0000 (+0200) Subject: Potential fix for pull request finding X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3d09fbad4376ce8dc0f833ecba6061534e6c1b37;p=ceph.git Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Guillaume Abrioux --- diff --git a/src/ceph-volume/ceph_volume/tests/util/test_disk.py b/src/ceph-volume/ceph_volume/tests/util/test_disk.py index 317b4afe446..7082c27d179 100644 --- a/src/ceph-volume/ceph_volume/tests/util/test_disk.py +++ b/src/ceph-volume/ceph_volume/tests/util/test_disk.py @@ -133,9 +133,14 @@ class TestBackingDeviceIsRotational(object): fake_filesystem.create_file('/sys/block/dm-0/queue/rotational', contents='0') assert disk.BackingDeviceRotation.is_rotational('/dev/dm-0') is True + @patch('ceph_volume.util.disk._kname_for_sysfs_walk', side_effect=lambda kname: kname) @patch('ceph_volume.util.disk.os.path.exists', return_value=True) @patch('ceph_volume.util.disk.UdevData') - def test_leaf_block_uses_udev_hints(self, m_udev, _m_exists): + def test_leaf_block_uses_udev_hints( + self, m_udev, _m_exists, _m_kname_for_sysfs_walk, fake_filesystem): + fake_filesystem.create_dir('/sys/block/sda') + fake_filesystem.create_dir('/sys/block/sdb') + m_udev.return_value.environment = {'ID_SSD': '1'} assert disk.BackingDeviceRotation._leaf_block_is_rotational('sda') is False