From: Jason Dillaman Date: Thu, 26 Mar 2015 01:23:00 +0000 (-0400) Subject: tests: correct update_features test for FAST_DIFF feature X-Git-Tag: v9.0.1~55^2~13 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3e7a342b4b6de33daaabee4444a915c8a9e3e501;p=ceph.git tests: correct update_features test for FAST_DIFF feature Signed-off-by: Jason Dillaman --- diff --git a/src/test/librbd/test_librbd.cc b/src/test/librbd/test_librbd.cc index 78aa476e8dbe..66bf4901572b 100644 --- a/src/test/librbd/test_librbd.cc +++ b/src/test/librbd/test_librbd.cc @@ -2870,16 +2870,26 @@ TEST_F(TestLibRBD, UpdateFeatures) ASSERT_EQ(-EINVAL, image.update_features(0, true)); ASSERT_EQ(0, image.update_features(RBD_FEATURE_EXCLUSIVE_LOCK | - RBD_FEATURE_OBJECT_MAP, false)); + RBD_FEATURE_OBJECT_MAP | + RBD_FEATURE_FAST_DIFF, false)); // cannot enable object map w/o exclusive lock ASSERT_EQ(-EINVAL, image.update_features(RBD_FEATURE_OBJECT_MAP, true)); - ASSERT_EQ(0, image.update_features(RBD_FEATURE_EXCLUSIVE_LOCK, true)); - ASSERT_EQ(0, image.update_features(RBD_FEATURE_OBJECT_MAP, true)); + + // cannot enable fast diff w/o object map + ASSERT_EQ(-EINVAL, image.update_features(RBD_FEATURE_FAST_DIFF, true)); + ASSERT_EQ(0, image.update_features(RBD_FEATURE_OBJECT_MAP | + RBD_FEATURE_FAST_DIFF, true)); + + // cannot disable object map w/ fast diff + ASSERT_EQ(-EINVAL, image.update_features(RBD_FEATURE_OBJECT_MAP, false)); + ASSERT_EQ(0, image.update_features(RBD_FEATURE_FAST_DIFF, false)); // cannot disable exclusive lock w/ object map ASSERT_EQ(-EINVAL, image.update_features(RBD_FEATURE_EXCLUSIVE_LOCK, false)); + ASSERT_EQ(0, image.update_features(RBD_FEATURE_OBJECT_MAP, false)); + ASSERT_EQ(0, image.update_features(RBD_FEATURE_EXCLUSIVE_LOCK, false)); } TEST_F(TestLibRBD, RebuildObjectMap)