From: David Zafman <david.zafman@inktank.com>
Date: Wed, 5 Mar 2014 23:08:41 +0000 (-0800)
Subject: Revert "c_read_operations.cc: fix resource leak"
X-Git-Tag: v0.78~82
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=3f59f02913f4277f419052d546bb7448f74aec4d;p=ceph.git

Revert "c_read_operations.cc: fix resource leak"

This reverts commit 3cd751b0a280909510c3e633cc8cd4b9f5e3b2d9.

A rados_release_read_op() has already been performed, but coverity
didn't recognize that as releasing memory.

Fixes: #7621

Signed-off-by: David Zafman <david.zafman@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>
---

diff --git a/src/test/librados/c_read_operations.cc b/src/test/librados/c_read_operations.cc
index 053b6147ba51..106f6b4f162d 100644
--- a/src/test/librados/c_read_operations.cc
+++ b/src/test/librados/c_read_operations.cc
@@ -365,7 +365,6 @@ TEST_F(CReadOpsTest, ExecUserBuf) {
 
   // buffer too short
   bytes_read = 1024;
-  rados_release_read_op(op);
   op = rados_create_read_op();
   rados_read_op_exec_user_buf(op, "rbd", "get_all_features", NULL, 0, out,
 			      sizeof(features) - 1, &bytes_read, &rval);