From: Casey Bodley <cbodley@redhat.com>
Date: Thu, 11 Apr 2024 19:52:26 +0000 (-0400)
Subject: test/rgw/pubsub: wait_for_queue_to_drain() supports tenant/account topics
X-Git-Tag: testing/wip-pdonnell-testing-20240416.232051-debug~25^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=400728481e2ba446ac2300565129a4ed55cf63b1;p=ceph-ci.git

test/rgw/pubsub: wait_for_queue_to_drain() supports tenant/account topics

Signed-off-by: Casey Bodley <cbodley@redhat.com>
---

diff --git a/src/test/rgw/bucket_notification/test_bn.py b/src/test/rgw/bucket_notification/test_bn.py
index 5003127fedf..fda0cf29173 100644
--- a/src/test/rgw/bucket_notification/test_bn.py
+++ b/src/test/rgw/bucket_notification/test_bn.py
@@ -3070,13 +3070,18 @@ def test_ps_s3_persistent_cleanup():
     http_server.close()
 
 
-def wait_for_queue_to_drain(topic_name):
+def wait_for_queue_to_drain(topic_name, tenant=None, account=None):
     retries = 0
     entries = 1
     start_time = time.time()
     # topic stats
+    cmd = ['topic', 'stats', '--topic', topic_name]
+    if tenant:
+        cmd += ['--tenant', tenant]
+    if account:
+        cmd += ['--account-id', account]
     while entries > 0:
-        result = admin(['topic', 'stats', '--topic', topic_name], get_config_cluster())
+        result = admin(cmd, get_config_cluster())
         assert_equal(result[1], 0)
         parsed_result = json.loads(result[0])
         entries = parsed_result['Topic Stats']['Entries']
@@ -3805,7 +3810,7 @@ def test_ps_s3_persistent_multiple_endpoints():
     conn.delete_bucket(bucket_name)
     http_server.close()
 
-def persistent_notification(endpoint_type, conn):
+def persistent_notification(endpoint_type, conn, account=None):
     """ test pushing persistent notification """
     zonegroup = get_config_zonegroup()
 
@@ -3877,7 +3882,7 @@ def persistent_notification(endpoint_type, conn):
 
     keys = list(bucket.list())
 
-    wait_for_queue_to_drain(topic_name)
+    wait_for_queue_to_drain(topic_name, account=account)
 
     receiver.verify_s3_events(keys, exact_match=exact_match, deletions=False)
 
@@ -3893,7 +3898,7 @@ def persistent_notification(endpoint_type, conn):
     time_diff = time.time() - start_time
     print('average time for deletion + async http notification is: ' + str(time_diff*1000/number_of_objects) + ' milliseconds')
 
-    wait_for_queue_to_drain(topic_name)
+    wait_for_queue_to_drain(topic_name, account=account)
 
     receiver.verify_s3_events(keys, exact_match=exact_match, deletions=True)
 
@@ -3922,11 +3927,11 @@ def test_ps_s3_persistent_notification_http_account():
     user = UID_PREFIX + 'test'
 
     _, result = admin(['account', 'create', '--account-id', account, '--account-name', 'testacct'], get_config_cluster())
-    assert_equal(result, 0)
+    assert_true(result in [0, 17]) # EEXIST okay if we rerun
 
     conn, _ = another_user(user=user, account=account)
     try:
-        persistent_notification('http', conn)
+        persistent_notification('http', conn, account)
     finally:
         admin(['user', 'rm', '--uid', user], get_config_cluster())
         admin(['account', 'rm', '--account-id', account], get_config_cluster())