From: Ronen Friedman <rfriedma@redhat.com>
Date: Sun, 3 Mar 2024 14:30:59 +0000 (+0200)
Subject: common: fix string creation from '0' in LogEntry
X-Git-Tag: v19.1.1~9^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=40169c168e8b09c797c847ab48f4e4a56e745833;p=ceph.git

common: fix string creation from '0' in LogEntry

C++23 disallows conversion from 'int' to 'string'.
That includes returning '0' from a function that returns a string.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit b854bfcc70ff372cd087c068e0302d36ad86391f)
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/src/common/LogEntry.cc b/src/common/LogEntry.cc
index d7b44a2110bd4..7bb49432268bb 100644
--- a/src/common/LogEntry.cc
+++ b/src/common/LogEntry.cc
@@ -183,7 +183,6 @@ string clog_type_to_string(clog_type t)
       return "crit";
     default:
       ceph_abort();
-      return 0;
   }
 }