From: Darrick J. Wong Date: Tue, 23 Mar 2021 04:19:48 +0000 (-0700) Subject: populate: create block devices when pre-populating filesystems X-Git-Tag: v2022.05.01~494 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=404d9f2b50abfa1d8837a1f1146c5218b76b7b48;p=xfstests-dev.git populate: create block devices when pre-populating filesystems I just noticed that the fs population helper creates a chardev file "S_IFBLK" on the scratch filesystem. This seems bogus (particularly since we actually also create a chardev named S_IFCHR) so fix up the mknod calls. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Eryu Guan --- diff --git a/common/populate b/common/populate index 4135d89d..8f42a528 100644 --- a/common/populate +++ b/common/populate @@ -230,7 +230,7 @@ _scratch_xfs_populate() { # Char & block echo "+ special" mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1 - mknod "${SCRATCH_MNT}/S_IFBLK" c 1 1 + mknod "${SCRATCH_MNT}/S_IFBLK" b 1 1 # special file with an xattr setfacl -P -m u:nobody:r ${SCRATCH_MNT}/S_IFCHR @@ -402,7 +402,7 @@ _scratch_ext4_populate() { # Char & block echo "+ special" mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1 - mknod "${SCRATCH_MNT}/S_IFBLK" c 1 1 + mknod "${SCRATCH_MNT}/S_IFBLK" b 1 1 # special file with an xattr setfacl -P -m u:nobody:r ${SCRATCH_MNT}/S_IFCHR