From: Ilya Dryomov <ilya.dryomov@inktank.com>
Date: Tue, 11 Mar 2014 16:11:38 +0000 (+0200)
Subject: OSDMap: clarify is_{down,in}() definitions
X-Git-Tag: v0.79~170^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=406ff0b71128c4fff99104ddac273efc82113dae;p=ceph.git

OSDMap: clarify is_{down,in}() definitions

Make it clear that is_down() == !is_up() and is_in() == !is_out().
This is not a functional change.

Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
---

diff --git a/src/osd/OSDMap.h b/src/osd/OSDMap.h
index 44da1b0e2b9a..2110bc5a7553 100644
--- a/src/osd/OSDMap.h
+++ b/src/osd/OSDMap.h
@@ -370,7 +370,7 @@ public:
   }
 
   bool is_down(int osd) const {
-    return !exists(osd) || !is_up(osd);
+    return !is_up(osd);
   }
 
   bool is_out(int osd) const {
@@ -378,7 +378,7 @@ public:
   }
 
   bool is_in(int osd) const {
-    return exists(osd) && !is_out(osd);
+    return !is_out(osd);
   }
 
   /**