From: amitkuma <amitkuma@redhat.com>
Date: Wed, 2 Aug 2017 17:34:06 +0000 (+0530)
Subject: client: NULL check before append value to bufferlist
X-Git-Tag: v13.0.1~986^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=40e9cad7756fbbd744997697f41af77920a322e1;p=ceph.git

client: NULL check before append value to bufferlist

Fixes the Coverity Scan Report:

** 1405275 Dereference after null check
CID 1405275 (#1 of 1): Dereference after null check (FORWARD_NULL)
5. var_deref_model: Passing null pointer value to append, which dereferences it.

Signed-off-by: Amit Kumar amitkuma@redhat.com
---

diff --git a/src/client/Client.cc b/src/client/Client.cc
index 6b34e4a330e4..3116a1b800d6 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -10679,6 +10679,7 @@ int Client::_do_setxattr(Inode *in, const char *name, const void *value,
   req->head.args.setxattr.flags = xattr_flags;
 
   bufferlist bl;
+  assert (value || size == 0);
   bl.append((const char*)value, size);
   req->set_data(bl);