From: John Mulligan Date: Tue, 6 Jun 2023 20:00:08 +0000 (-0400) Subject: cephadm: reformat deploy_daemon arguments to make it readable X-Git-Tag: v19.0.0~711^2~25 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=41bda43ebd645a1079db89ada55b0fe7a2450d69;p=ceph-ci.git cephadm: reformat deploy_daemon arguments to make it readable Reformat the deploy_daemon function's arguments to use the "black" one-line-per-argument style, which is significantly more readable IMO. Signed-off-by: John Mulligan --- diff --git a/src/cephadm/cephadm.py b/src/cephadm/cephadm.py index 184316a63ca..eaa52d3ff95 100755 --- a/src/cephadm/cephadm.py +++ b/src/cephadm/cephadm.py @@ -3648,13 +3648,20 @@ def extract_uid_gid(ctx, img='', file_path='/var/lib/ceph'): raise RuntimeError('uid/gid not found') -def deploy_daemon(ctx: CephadmContext, fsid: str, daemon_type: str, - daemon_id: Union[int, str], c: Optional['CephContainer'], - uid: int, gid: int, config: Optional[str] = None, - keyring: Optional[str] = None, osd_fsid: Optional[str] = None, - deployment_type: DeploymentType = DeploymentType.DEFAULT, - ports: Optional[List[int]] = None) -> None: - +def deploy_daemon( + ctx: CephadmContext, + fsid: str, + daemon_type: str, + daemon_id: Union[int, str], + c: Optional['CephContainer'], + uid: int, + gid: int, + config: Optional[str] = None, + keyring: Optional[str] = None, + osd_fsid: Optional[str] = None, + deployment_type: DeploymentType = DeploymentType.DEFAULT, + ports: Optional[List[int]] = None, +) -> None: ports = ports or [] # only check port in use if fresh deployment since service # we are redeploying/reconfiguring will already be using the port