From: Zhang Song <zhangsong325@gmail.com>
Date: Mon, 17 Oct 2022 06:40:41 +0000 (+0800)
Subject: crimson/osd: fix use after free error in FuturizedStoreLogReader::read
X-Git-Tag: v18.1.0~336^2~10^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=41c6456a4333df49ab708277dd8881a42a952961;p=ceph-ci.git

crimson/osd: fix use after free error in FuturizedStoreLogReader::read

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
---

diff --git a/src/osd/PGLog.cc b/src/osd/PGLog.cc
index 8a45b3af515..1d00e3a8a31 100644
--- a/src/osd/PGLog.cc
+++ b/src/osd/PGLog.cc
@@ -1146,37 +1146,41 @@ namespace {
       on_disk_can_rollback_to = info.last_update;
       missing.may_include_deletes = false;
 
-      return seastar::repeat([ch=std::move(ch),
-                              pgmeta_oid=std::move(pgmeta_oid),
-                              start=std::make_optional<std::string>(),
-                              this]() mutable {
-        return store.omap_get_values(
-          ch, pgmeta_oid, start
-        ).safe_then([this, &start](const auto& ret) mutable {
-          const auto& [done, kvs] = ret;
-          for (const auto& [key, value] : kvs) {
-            process_entry(key, value);
-            // I trust the compiler will optimize this out
-            start = key;
-          }
-          return seastar::make_ready_future<seastar::stop_iteration>(
-            done ? seastar::stop_iteration::yes : seastar::stop_iteration::no
-          );
-        }, crimson::os::FuturizedStore::read_errorator::assert_all{});
-      }).then([this] {
-        if (info.pgid.is_no_shard()) {
-          // replicated pool pg does not persist this key
-          assert(on_disk_rollback_info_trimmed_to == eversion_t());
-          on_disk_rollback_info_trimmed_to = info.last_update;
-        }
-        log = PGLog::IndexedLog(
-             info.last_update,
-             info.log_tail,
-             on_disk_can_rollback_to,
-             on_disk_rollback_info_trimmed_to,
-             std::move(entries),
-             std::move(dups));
-      });
+      return seastar::do_with(
+        std::move(ch),
+        std::move(pgmeta_oid),
+        std::make_optional<std::string>(),
+        [this](crimson::os::CollectionRef &ch,
+               ghobject_t &pgmeta_oid,
+               std::optional<std::string> &start) {
+          return seastar::repeat([this, &ch, &pgmeta_oid, &start]() {
+            return store.omap_get_values(
+              ch, pgmeta_oid, start
+            ).safe_then([this, &start](const auto& ret) {
+              const auto& [done, kvs] = ret;
+              for (const auto& [key, value] : kvs) {
+                process_entry(key, value);
+                start = key;
+              }
+              return seastar::make_ready_future<seastar::stop_iteration>(
+                done ? seastar::stop_iteration::yes : seastar::stop_iteration::no
+              );
+            }, crimson::os::FuturizedStore::read_errorator::assert_all{});
+          }).then([this] {
+            if (info.pgid.is_no_shard()) {
+              // replicated pool pg does not persist this key
+              assert(on_disk_rollback_info_trimmed_to == eversion_t());
+              on_disk_rollback_info_trimmed_to = info.last_update;
+            }
+            log = PGLog::IndexedLog(
+                 info.last_update,
+                 info.log_tail,
+                 on_disk_can_rollback_to,
+                 on_disk_rollback_info_trimmed_to,
+                 std::move(entries),
+                 std::move(dups));
+          });
+        });
     }
   };
 }