From: Samuel Just <sjust@redhat.com>
Date: Thu, 6 Oct 2022 01:56:26 +0000 (-0700)
Subject: crimson/osd/pg_backend: remove incorrect length limitation on CMPEXT
X-Git-Tag: v18.1.0~336^2~38^2~2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=41d89ed265777d7c6d4247075d529439f08c2812;p=ceph-ci.git

crimson/osd/pg_backend: remove incorrect length limitation on CMPEXT

We specifically send back errors < -MAX_ERRNO to indicate offset.

Fixes: https://tracker.ceph.com/issues/57773
Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/crimson/osd/pg_backend.cc b/src/crimson/osd/pg_backend.cc
index 8e02d3591c0..253848da7f1 100644
--- a/src/crimson/osd/pg_backend.cc
+++ b/src/crimson/osd/pg_backend.cc
@@ -423,11 +423,6 @@ PGBackend::cmp_ext_ierrorator::future<>
 PGBackend::cmp_ext(const ObjectState& os, OSDOp& osd_op)
 {
   const ceph_osd_op& op = osd_op.op;
-  // return the index of the first unmatched byte in the payload, hence the
-  // strange limit and check
-  if (op.extent.length > MAX_ERRNO) {
-    return crimson::ct_error::invarg::make();
-  }
   uint64_t obj_size = os.oi.size;
   if (os.oi.truncate_seq < op.extent.truncate_seq &&
       op.extent.offset + op.extent.length > op.extent.truncate_size) {