From: Sebastian Wagner <sebastian.wagner@suse.com>
Date: Wed, 10 Jun 2020 13:40:34 +0000 (+0200)
Subject: mgr/dashboard: pylint: reduce number of branches
X-Git-Tag: wip-pdonnell-testing-20200918.022351~1018^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=4215ad58275ecaae45bb1b494085e753aa854356;p=ceph-ci.git

mgr/dashboard: pylint: reduce number of branches

fixes: `R0912: Too many branches (14/12) (too-many-branches)`
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
---

diff --git a/src/pybind/mgr/dashboard/controllers/mgr_modules.py b/src/pybind/mgr/dashboard/controllers/mgr_modules.py
index d296d17fbf3..0d4cc522256 100644
--- a/src/pybind/mgr/dashboard/controllers/mgr_modules.py
+++ b/src/pybind/mgr/dashboard/controllers/mgr_modules.py
@@ -158,16 +158,13 @@ class MgrModules(RESTController):
                 else:
                     option['default_value'] = str_to_bool(
                         option['default_value'])
-            elif option['type'] == 'float':
+            elif option['type'] in ['float', 'uint', 'int', 'size', 'secs']:
+                cls = {
+                    'float': float
+                }.get(option['type'], int)
                 for name in ['default_value', 'min', 'max']:
                     if option[name] == 'None':  # This is Python None
                         option[name] = None
                     elif option[name]:  # Skip empty entries
-                        option[name] = float(option[name])
-            elif option['type'] in ['uint', 'int', 'size', 'secs']:
-                for name in ['default_value', 'min', 'max']:
-                    if option[name] == 'None':  # This is Python None
-                        option[name] = None
-                    elif option[name]:  # Skip empty entries
-                        option[name] = int(option[name])
+                        option[name] = cls(option[name])
         return options