From: Kefu Chai Date: Wed, 9 Sep 2020 03:46:01 +0000 (+0800) Subject: crimson/osd: print notify_id instead of its address X-Git-Tag: v16.1.0~1157^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4234c3f6c0147f348c4955e8272aa241c77d3cf4;p=ceph.git crimson/osd: print notify_id instead of its address this addresses the FTBFS like /usr/include/fmt/core.h:902:19: error: static assertion failed: formatting of non-void pointers is disallowed 902 | static_assert(!sizeof(T), "formatting of non-void pointers is disallowed"); | ^~~~~~~~~~ also, i think it is more helpful in this context to have the notify id instead of the address, as we can use the id to reference the notification printed by other logging messages. Signed-off-by: Kefu Chai --- diff --git a/src/crimson/osd/watch.cc b/src/crimson/osd/watch.cc index 68eea9277d71..a7a3311aa9b6 100644 --- a/src/crimson/osd/watch.cc +++ b/src/crimson/osd/watch.cc @@ -44,7 +44,7 @@ seastar::future<> Watch::send_notify_msg(NotifyRef notify) seastar::future<> Watch::start_notify(NotifyRef notify) { - logger().info("{} adding ¬ify={}", __func__, notify.get()); + logger().info("{} adding notify(id={})", __func__, notify->ninfo.notify_id); auto [ it, emplaced ] = in_progress_notifies.emplace(std::move(notify)); ceph_assert(emplaced); ceph_assert(is_alive());