From: sp98 Date: Thu, 7 Dec 2023 10:48:05 +0000 (+0530) Subject: mds: change priority of mds rss perf counter to useful X-Git-Tag: v17.2.8~575^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=42ccfe6aa4fa7cde31d07a9bb37b9da3272050a5;p=ceph.git mds: change priority of mds rss perf counter to useful mds_cache_mem_rss perf counter can be a useful metric to detect the usage of mds cache and detect mds cache oversize before it happens. The PR changes the priority of the mds_rss metric from Debug to useful Fixes: https://tracker.ceph.com/issues/63765 Signed-off-by: sp98 (cherry picked from commit 89b9fa299c0fe80b3e8619dd9dd8cb77e5b08016) --- diff --git a/src/mds/MDSRank.cc b/src/mds/MDSRank.cc index 8d41a4678f88a..4eb94e4106a9d 100644 --- a/src/mds/MDSRank.cc +++ b/src/mds/MDSRank.cc @@ -3472,6 +3472,9 @@ void MDSRank::create_logger() PerfCountersBuilder::PRIO_INTERESTING); mdm_plb.add_u64(l_mdm_dn, "dn", "Dentries", "dn", PerfCountersBuilder::PRIO_INTERESTING); + // mds rss metric is set to PRIO_USEFUL as it can be useful to detect mds cache oversizing + mdm_plb.add_u64(l_mdm_rss, "rss", "RSS", "rss", + PerfCountersBuilder::PRIO_USEFUL); mdm_plb.set_prio_default(PerfCountersBuilder::PRIO_USEFUL); mdm_plb.add_u64_counter(l_mdm_inoa, "ino+", "Inodes opened"); @@ -3486,9 +3489,6 @@ void MDSRank::create_logger() mdm_plb.add_u64_counter(l_mdm_caps, "cap-", "Capabilities removed"); mdm_plb.add_u64(l_mdm_heap, "heap", "Heap size"); - mdm_plb.set_prio_default(PerfCountersBuilder::PRIO_DEBUGONLY); - mdm_plb.add_u64(l_mdm_rss, "rss", "RSS"); - mlogger = mdm_plb.create_perf_counters(); g_ceph_context->get_perfcounters_collection()->add(mlogger); }