From: Nikhilkumar Shelke Date: Sun, 12 Jun 2022 16:28:40 +0000 (+0530) Subject: mgr/volumes: subvolume ls command crashes if groupname as '_nogroup' X-Git-Tag: v16.2.11~444^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=42d9db4bee3d350d3d827dc46614449196538d0e;p=ceph.git mgr/volumes: subvolume ls command crashes if groupname as '_nogroup' If --group_name=_nogroup is provided in the command then throw error permission denied as it is internal group of ceph fs. Fixes: https://tracker.ceph.com/issues/55759 Signed-off-by: Nikhilkumar Shelke (cherry picked from commit acf1337334faca2ef021294bf7a8367193072484) --- diff --git a/src/pybind/mgr/volumes/fs/operations/group.py b/src/pybind/mgr/volumes/fs/operations/group.py index d64e7fcdb3e8..7916253e2129 100644 --- a/src/pybind/mgr/volumes/fs/operations/group.py +++ b/src/pybind/mgr/volumes/fs/operations/group.py @@ -19,7 +19,8 @@ class Group(GroupTemplate): NO_GROUP_NAME = "_nogroup" def __init__(self, fs, vol_spec, groupname): - assert groupname != Group.NO_GROUP_NAME + if groupname == Group.NO_GROUP_NAME: + raise VolumeException(-errno.EPERM, "Operation not permitted for group '{0}' as it is an internal group.".format(groupname)) self.fs = fs self.user_id = None self.group_id = None