From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Mon, 4 May 2015 23:06:44 +0000 (+0200)
Subject: os/FileStore.cc: remove dead code
X-Git-Tag: v9.0.2~68^2~10
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=42f93a641804d9a3baeb01b1be4ecb86d4e0eb26;p=ceph.git

os/FileStore.cc: remove dead code

Fix for coverity issue caused by 8811df3 (introduced a similar
check some lines earlier in the code causing the check to return
earlier).

at_least: At condition r < 0, the value of r must be at least 0.
dead_error_condition: The condition r < 0 cannot be true.

CID 1274289 (#1 of 1): Logically dead code (DEADCODE)
dead_error_begin: Execution cannot reach this statement

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/os/FileStore.cc b/src/os/FileStore.cc
index 38c85330dbef..1cc059b08314 100644
--- a/src/os/FileStore.cc
+++ b/src/os/FileStore.cc
@@ -270,11 +270,7 @@ int FileStore::lfn_open(coll_t cid,
 
   IndexedPath path2;
   IndexedPath *path = &path2;
-  if (r < 0) {
-    derr << "error getting collection index for " << cid
-      << ": " << cpp_strerror(-r) << dendl;
-    goto fail;
-  }
+
   r = (*index)->lookup(oid, path, &exist);
   if (r < 0) {
     derr << "could not find " << oid << " in index: "