From: Ilya Dryomov Date: Fri, 8 Apr 2022 13:53:38 +0000 (+0200) Subject: librbd/cache/pwl: no need to set clean and empty in remove_pool_file() X-Git-Tag: v17.2.1~87^2~7 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=444bc6e5a8d17202c276d8128f7ca656d598e9ed;p=ceph.git librbd/cache/pwl: no need to set clean and empty in remove_pool_file() It is redundant -- the only caller sets both since commit 6593e31fff18 ("librbd/cache/pwl: correct cache state"). Signed-off-by: Ilya Dryomov (cherry picked from commit d64a3ae265897806809d9fa08ac72c549b4bca4f) --- diff --git a/src/librbd/cache/pwl/rwl/WriteLog.cc b/src/librbd/cache/pwl/rwl/WriteLog.cc index 335dea83e8339..eb096f9187679 100644 --- a/src/librbd/cache/pwl/rwl/WriteLog.cc +++ b/src/librbd/cache/pwl/rwl/WriteLog.cc @@ -250,8 +250,6 @@ void WriteLog::remove_pool_file() { lderr(m_image_ctx.cct) << "failed to remove empty pool \"" << this->m_log_pool_name << "\": " << pmemobj_errormsg() << dendl; } else { - m_cache_state->clean = true; - m_cache_state->empty = true; m_cache_state->present = false; } } else { diff --git a/src/librbd/cache/pwl/ssd/WriteLog.cc b/src/librbd/cache/pwl/ssd/WriteLog.cc index f705198b60d46..8bee4ee255f33 100644 --- a/src/librbd/cache/pwl/ssd/WriteLog.cc +++ b/src/librbd/cache/pwl/ssd/WriteLog.cc @@ -271,8 +271,6 @@ void WriteLog::remove_pool_file() { lderr(m_image_ctx.cct) << "failed to remove empty pool \"" << this->m_log_pool_name << "\": " << dendl; } else { - m_cache_state->clean = true; - m_cache_state->empty = true; m_cache_state->present = false; } } else {