From: Somnath Roy <somnath.roy@sandisk.com>
Date: Fri, 27 Jun 2014 01:53:11 +0000 (-0700)
Subject: MOSDOpreply: The functions are returned by const ref and parameters passed by ref
X-Git-Tag: v0.84~121^2~5
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=44db3d04aeed6f04a4ee9ac786f02929576ca328;p=ceph.git

MOSDOpreply: The functions are returned by const ref and parameters passed by ref

get_oid,get_pg,get_replay_version,get_user_version are returning by reference and
corresponding setter is accepting param by reference.

Signed-off-by: Somnath Roy <somnath.roy@sandisk.com>
---

diff --git a/src/messages/MOSDOpReply.h b/src/messages/MOSDOpReply.h
index 91c50e76dc26..4a677d68180d 100644
--- a/src/messages/MOSDOpReply.h
+++ b/src/messages/MOSDOpReply.h
@@ -48,16 +48,16 @@ class MOSDOpReply : public Message {
   request_redirect_t redirect;
 
 public:
-  object_t get_oid() const { return oid; }
-  pg_t     get_pg() const { return pgid; }
+  const object_t& get_oid() const { return oid; }
+  const pg_t&     get_pg() const { return pgid; }
   int      get_flags() const { return flags; }
 
   bool     is_ondisk() const { return get_flags() & CEPH_OSD_FLAG_ONDISK; }
   bool     is_onnvram() const { return get_flags() & CEPH_OSD_FLAG_ONNVRAM; }
   
   int get_result() const { return result; }
-  eversion_t get_replay_version() const { return replay_version; }
-  version_t get_user_version() const { return user_version; }
+  const eversion_t& get_replay_version() const { return replay_version; }
+  const version_t& get_user_version() const { return user_version; }
   
   void set_result(int r) { result = r; }
 
@@ -84,7 +84,7 @@ public:
   }
 
   /* Don't fill in replay_version for non-write ops */
-  void set_enoent_reply_versions(eversion_t v, version_t uv) {
+  void set_enoent_reply_versions(const eversion_t& v, const version_t& uv) {
     user_version = uv;
     bad_replay_version = v;
   }