From: Radosław Zarzyński Date: Tue, 24 Oct 2023 10:48:25 +0000 (+0200) Subject: crimson/osd: improve debugs in ECBackend::handle_rep_write_reply X-Git-Tag: v21.0.0~3^2~70 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=46b32c2205b47a28390fd984956fa463febb3f48;p=ceph.git crimson/osd: improve debugs in ECBackend::handle_rep_write_reply Signed-off-by: Radosław Zarzyński --- diff --git a/src/crimson/osd/ec_backend.cc b/src/crimson/osd/ec_backend.cc index 5dbc96698a76..ddc4891ba2bc 100644 --- a/src/crimson/osd/ec_backend.cc +++ b/src/crimson/osd/ec_backend.cc @@ -402,11 +402,15 @@ ECBackend::handle_rep_write_op( ECBackend::write_iertr::future<> ECBackend::handle_rep_write_reply(ECSubWriteReply&& op) { + LOG_PREFIX(ECBackend::handle_rep_write_reply); + DEBUG("handling reply from osd.{}, tid {}", op.from.osd, op.tid); assert(rmw_pipeline.tid_to_op_map.contains(op.tid)); const auto& from = op.from; auto& wop = *rmw_pipeline.tid_to_op_map.at(op.tid); if (op.committed) { // TODO: trace.event("sub write committed"); + logger().debug("ECBackend::{} from {} pending_commit {}", + __func__, from, wop.pending_commit); ceph_assert(wop.pending_commit.count(from)); wop.pending_commit.erase(from); } @@ -420,7 +424,7 @@ ECBackend::handle_rep_write_reply(ECSubWriteReply&& op) wop.on_all_commit && // also wait for apply, to preserve ordering with luminous peers. wop.pending_apply.empty()) { - logger().info("{}: calling on_all_commit on {}", __func__, wop); + logger().info("ECBackend::{}: calling on_all_commit on {}", __func__, wop); wop.on_all_commit->complete(0); wop.on_all_commit = 0; // TODO: wop.trace.event("ec write all committed");