From: Sage Weil <sage@inktank.com>
Date: Sat, 25 Aug 2012 03:02:14 +0000 (-0700)
Subject: log: protect m_stop with lock
X-Git-Tag: v0.53~229^2~23
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=46c08d6c287741875167db7073e18251d4b669dc;p=ceph.git

log: protect m_stop with lock

CID 716965: Data race condition (MISSING_LOCK)
At (2): Accessing "this->m_stop" ("_ZN4ceph3log3LogE.m_stop") requires the "_ZN4ceph3log3LogE.m_queue_mutex" lock.

This isn't strictly needed since we assume only one thread will call this
method and start a thead, but it makes coverity happy.

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/log/Log.cc b/src/log/Log.cc
index f418a8ac6af0..32d8be79c455 100644
--- a/src/log/Log.cc
+++ b/src/log/Log.cc
@@ -288,7 +288,9 @@ void Log::dump_recent()
 void Log::start()
 {
   assert(!is_started());
+  pthread_mutex_lock(&m_queue_mutex);
   m_stop = false;
+  pthread_mutex_unlock(&m_queue_mutex);
   create();
 }