From: Afreen Misbah <afreen23.git@gmail.com>
Date: Tue, 3 Sep 2024 06:48:46 +0000 (+0530)
Subject: mgr/dashboard: Fixed bug in service form
X-Git-Tag: v19.2.1~252^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=47514db2e6e5c79ad27181517868f8876352c449;p=ceph.git

mgr/dashboard: Fixed bug in service form

The commit in main went through this PR https://github.com/ceph/ceph/pull/59496/commits/6c25635be8c2ec0c2f637c4fe6952f781c1ad12c

This PR wont be backported to squid hence adding the change in separate commit.

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
---

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts
index a37cca340142b..9602c856aed81 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts
@@ -195,7 +195,12 @@ export class ServiceFormComponent extends CdForm implements OnInit {
           })
         ]
       ],
-      group: [null, Validators.required],
+      group: [
+        null,
+        CdValidators.requiredIf({
+          service_type: 'nvmeof'
+        })
+      ],
       // RGW
       rgw_frontend_port: [null, [CdValidators.number(false)]],
       realm_name: [null],