From: Kefu Chai <kchai@redhat.com>
Date: Sun, 19 Aug 2018 04:16:24 +0000 (+0800)
Subject: test/librados: do not use assert() for its side effect
X-Git-Tag: v14.0.1~540^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=487ecd7141cf0708f14a11d82bb5b2cd63df3225;p=ceph.git

test/librados: do not use assert() for its side effect

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/test/librados/test_common.cc b/src/test/librados/test_common.cc
index f617fa6bca7e..f8f7de7906af 100644
--- a/src/test/librados/test_common.cc
+++ b/src/test/librados/test_common.cc
@@ -44,7 +44,8 @@ int wait_for_healthy(rados_t *cluster)
     rados_buffer_free(outbuf);
 
     json_spirit::mValue root;
-    assert(json_spirit::read(out, root));
+    [[maybe_unused]] bool json_parse_success = json_spirit::read(out, root);
+    assert(json_parse_success);
     json_spirit::mObject root_obj = root.get_obj();
     json_spirit::mObject pgmap = root_obj["pgmap"].get_obj();
     json_spirit::mArray pgs_by_state = pgmap["pgs_by_state"].get_array();