From: Patrick Donnelly <pdonnell@redhat.com>
Date: Thu, 23 May 2024 19:58:48 +0000 (-0400)
Subject: mds: unconditionally dump message in formatter
X-Git-Tag: v20.0.0~1818^2~2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=48a25e3336590a6f3540094b29b9e8b46de5ad06;p=ceph.git

mds: unconditionally dump message in formatter

It's unpleasant to test for existence in json. Just dump an empty string if not present.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
---

diff --git a/src/mds/MDSRank.cc b/src/mds/MDSRank.cc
index 083edc7120e9c..783ffccc5aefb 100644
--- a/src/mds/MDSRank.cc
+++ b/src/mds/MDSRank.cc
@@ -2668,8 +2668,7 @@ void MDSRankDispatcher::handle_asok_command(
 
     void finish(int rc) override {
       f->open_object_section("result");
-      if (!ss.view().empty()) {
-        f->dump_string("message", ss.view());
+      f->dump_string("message", ss.view());
       f->dump_int("return_code", rc);
       f->close_section();