From: Adam C. Emerson <aemerson@redhat.com>
Date: Fri, 15 Mar 2019 19:22:05 +0000 (-0400)
Subject: rgw: Avoid signedness weirdness
X-Git-Tag: v15.0.0~178^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=48c1e44d573ef43a798352994db7c98de287f25c;p=ceph.git

rgw: Avoid signedness weirdness

If `char` is signed, then every `char` will be less than 255. Thus,
declare `e` as `unsigned char`.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
---

diff --git a/src/rgw/rgw_rados.cc b/src/rgw/rgw_rados.cc
index 7ae743acadcc..0c5e9ceba49c 100644
--- a/src/rgw/rgw_rados.cc
+++ b/src/rgw/rgw_rados.cc
@@ -2432,7 +2432,7 @@ int RGWRados::Bucket::update_bucket_id(const string& new_bucket_id)
 static inline std::string after_delim(std::string_view delim)
 {
   // assert: ! delim.empty()
-  char e = delim.back();
+  unsigned char e = delim.back();
   delim.remove_suffix(1);
   std::string result{delim.data(), delim.length()};
   if (e < 255) {