From: Anoop C S <anoopcs@cryptolab.net>
Date: Wed, 10 Jul 2024 17:29:51 +0000 (+0530)
Subject: mgr/smb: Replace "clusters" with "shares" in error status
X-Git-Tag: testing/wip-vshankar-testing-20240718.183435-debug~5^2~2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=48d8279dc7722f28fbba428e250baa8e4637f127;p=ceph-ci.git

mgr/smb: Replace "clusters" with "shares" in error status

In the following error response the list of active shares is incorrectly
displayed with "clusters" field.
{
  "resource": {
    "resource_type": "ceph.smb.cluster",
    "cluster_id": "smbcluster",
    "intent": "removed"
  },
  "clusters": [
    "smbshare"
  ],
  "msg": "cluster in use by shares",
  "success": false
}

Replace "clusters" with "shares" to avoid confusion.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
---

diff --git a/src/pybind/mgr/smb/handler.py b/src/pybind/mgr/smb/handler.py
index 84702e72f78..510715bb2b6 100644
--- a/src/pybind/mgr/smb/handler.py
+++ b/src/pybind/mgr/smb/handler.py
@@ -758,7 +758,7 @@ def _check_cluster(cluster: ClusterRef, staging: _Staging) -> None:
                 cluster,
                 msg="cluster in use by shares",
                 status={
-                    'clusters': [
+                    'shares': [
                         shid
                         for cid, shid in share_ids
                         if cid == cluster.cluster_id