From: John Mulligan Date: Tue, 20 Feb 2024 00:18:08 +0000 (-0500) Subject: qa/tasks: make _map_vips private X-Git-Tag: testing/wip-yuriw-testing-20240419.202307-squid~18^2~32 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=49205a3a7297d859fc888c2bd5493189090704b9;p=ceph-ci.git qa/tasks: make _map_vips private Nothing outside of vip.py called map_vips, so let us make sure this is considered a private function and prefix it with the underscore. Signed-off-by: John Mulligan (cherry picked from commit addc970c1991d6d1e9f0cbc736c279fcde003775) --- diff --git a/qa/tasks/vip.py b/qa/tasks/vip.py index 8e5f44efd6d..6554f128753 100644 --- a/qa/tasks/vip.py +++ b/qa/tasks/vip.py @@ -69,7 +69,7 @@ def exec(ctx, config): ) -def map_vips(mip, count): +def _map_vips(mip, count): vip_entries = teuth_config.get('vip', []) if not vip_entries: raise ConfigError( @@ -146,7 +146,7 @@ def task(ctx, config): ip = remote.ssh.get_transport().getpeername()[0] log.info(f'peername {ip}') mip = ipaddress.ip_address(ip) - vnet, vips = map_vips(mip, count + 1) + vnet, vips = _map_vips(mip, count + 1) static = vips.pop(0) log.info(f"{remote.hostname} static {static}, vnet {vnet}")