From: Aashish Sharma <aasharma@li-e74156cc-2f67-11b2-a85c-e98659a63c5c.ibm.com>
Date: Fri, 20 Sep 2024 05:36:21 +0000 (+0530)
Subject: mgr/dashboard: fix handling NaN values in dashboard charts
X-Git-Tag: v20.0.0~986^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=49ee68245b78779ffd6766f143315b5bf526afda;p=ceph.git

mgr/dashboard: fix handling NaN values in dashboard charts

Fixes: https://tracker.ceph.com/issues/68162

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
---

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/prometheus.service.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/prometheus.service.ts
index 1a241361f7f2..317293be07ce 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/prometheus.service.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/prometheus.service.ts
@@ -143,7 +143,6 @@ export class PrometheusService {
       }
       this.timerGetPrometheusDataSub = timer(0, this.timerTime).subscribe(() => {
         selectedTime = this.updateTimeStamp(selectedTime);
-
         for (const queryName in queries) {
           if (queries.hasOwnProperty(queryName)) {
             const query = queries[queryName];
@@ -163,13 +162,12 @@ export class PrometheusService {
                 queriesResults[queryName] !== '' &&
                 checkNan
               ) {
-                queriesResults[queryName].forEach((valueArray: string[]) => {
-                  if (valueArray.includes('NaN')) {
-                    const index = valueArray.indexOf('NaN');
-                    if (index !== -1) {
-                      valueArray[index] = '0';
+                queriesResults[queryName].forEach((valueArray: any[]) => {
+                  valueArray.forEach((val, index) => {
+                    if (isNaN(parseFloat(val[1]))) {
+                      valueArray[index][1] = '0';
                     }
-                  }
+                  });
                 });
               }
             });