From: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Date: Fri, 21 Apr 2023 13:10:23 +0000 (+0000)
Subject: cmake: avoid -Bsymbolic on Windows
X-Git-Tag: v19.0.0~575^2~10
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4a0dceec99c003bb624f561757185f4603d7badc;p=ceph.git

cmake: avoid -Bsymbolic on Windows

The "-Bsymbolic" and "-Bsymbolic-functions" flags only apply to ELF
binaries.

llvm errors out when targeting Windows, which is why we'll need
to skip those flags for Windows builds.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
---

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 21f83a44b677..8287539a3fc7 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -570,7 +570,7 @@ endif()
 set_target_properties(ceph-common PROPERTIES
   SOVERSION 2
   SKIP_RPATH TRUE)
-if(NOT APPLE AND NOT FREEBSD)
+if(NOT APPLE AND NOT FREEBSD AND NOT WIN32)
   # Apple uses Mach-O, not ELF. so this option does not apply to APPLE.
   #
   # prefer the local symbol definitions when binding references to global