From: Kefu Chai Date: Wed, 4 Nov 2020 09:56:33 +0000 (+0800) Subject: crimson/osd: mark methods pure virtual X-Git-Tag: v16.1.0~688^2~5 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4b8ac1ba4b36d0c9e2ea1cba1e64d534ba931333;p=ceph.git crimson/osd: mark methods pure virtual if the default implementation does not make sense in any case, just mark it pure virtual. Signed-off-by: Kefu Chai --- diff --git a/src/crimson/os/futurized_store.h b/src/crimson/os/futurized_store.h index d7f3d585426b..744ef356e356 100644 --- a/src/crimson/os/futurized_store.h +++ b/src/crimson/os/futurized_store.h @@ -28,21 +28,13 @@ class FuturizedStore { public: class OmapIterator { public: - virtual seastar::future<> seek_to_first() { - return seastar::make_ready_future<>(); - } - virtual seastar::future<> upper_bound(const std::string &after) { - return seastar::make_ready_future<>(); - } - virtual seastar::future<> lower_bound(const std::string &to) { - return seastar::make_ready_future<>(); - } + virtual seastar::future<> seek_to_first() = 0; + virtual seastar::future<> upper_bound(const std::string &after) = 0; + virtual seastar::future<> lower_bound(const std::string &to) = 0; virtual bool valid() const { return false; } - virtual seastar::future<> next() { - return seastar::make_ready_future<>(); - } + virtual seastar::future<> next() = 0; virtual std::string key() { return {}; }