From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Wed, 13 Feb 2013 16:48:48 +0000 (+0100)
Subject: librbd/internal.cc: use !empty() instead of size()
X-Git-Tag: v0.58~66^2~25
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4c11a5d135f0cd05a871a545c02d3ae59dd43c1e;p=ceph.git

librbd/internal.cc: use !empty() instead of size()

Use empty() since it should be prefered as it has, following the
standard, a constant time complexity regardless of the containter
type. The same is not guaranteed for size().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/librbd/internal.cc b/src/librbd/internal.cc
index fdadf6f6753f..33b948d23104 100644
--- a/src/librbd/internal.cc
+++ b/src/librbd/internal.cc
@@ -360,7 +360,7 @@ namespace librbd {
 	   it != images.end(); ++it) {
 	names.push_back(it->first);
       }
-      if (images.size()) {
+      if (!images.empty()) {
 	last_read = images.rbegin()->first;
       }
       r = images.size();
@@ -1056,7 +1056,7 @@ reprotect_and_return_err:
 	return r;
       }
       omap_values.insert(outbl.begin(), outbl.end());
-      if (outbl.size() > 0)
+      if (!outbl.empty())
 	last_read = outbl.rbegin()->first;
     } while (r == MAX_READ);
 
@@ -1074,7 +1074,7 @@ reprotect_and_return_err:
     librados::ObjectWriteOperation op;
     op.create(true);
     op.write_full(databl);
-    if (omap_values.size())
+    if (!omap_values.empty())
       op.omap_set(omap_values);
     r = io_ctx.operate(dst_oid, &op);
     if (r < 0) {