From: Justin Caratzas Date: Mon, 6 Oct 2025 23:25:43 +0000 (-0400) Subject: pybind/mgr: Correct code to ensure cephadm/tests/test_certmgr.py passes. X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4c1d3b826df2cc7432dffcf07b879919dff99d6f;p=ceph-ci.git pybind/mgr: Correct code to ensure cephadm/tests/test_certmgr.py passes. Signed-off-by: Paulo E. Castro (cherry picked from commit 218d84fc15d818d2df56c92cd71aeb2aa85f1590) Resolves: rhbz#2401206 --- diff --git a/src/pybind/mgr/mgr_util.py b/src/pybind/mgr/mgr_util.py index 6298612105a..802b040051d 100644 --- a/src/pybind/mgr/mgr_util.py +++ b/src/pybind/mgr/mgr_util.py @@ -683,8 +683,8 @@ def get_cert_issuer_info(crt: str) -> Tuple[Optional[str], Optional[str]]: def verify_tls(crt, key): # type: (str, str) -> int cc = ceph.cryptotools.remote.CryptoCaller() - days_to_expiration = cc.verify_cacrt_content(crt) try: + days_to_expiration = cc.verify_cacrt_content(crt) cc.verify_tls(crt, key) except ValueError as err: raise ServerConfigException(str(err)) diff --git a/src/python-common/ceph/cryptotools/remote.py b/src/python-common/ceph/cryptotools/remote.py index a83399828e1..9a668ca4bfa 100644 --- a/src/python-common/ceph/cryptotools/remote.py +++ b/src/python-common/ceph/cryptotools/remote.py @@ -124,6 +124,7 @@ class CryptoCaller: self._run( ['verify_tls'], input_data=json.dumps({'crt': crt, 'key': key}), + capture_output=True, check=True, )