From: Tomer Haskalovitch Date: Mon, 23 Jun 2025 20:23:05 +0000 (+0300) Subject: mgr/dashboard: migrate nvmeof pr #1238 to new cli X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4c6304e7ff1e2df469b7f6e26337e5cfa13bc4b2;p=ceph.git mgr/dashboard: migrate nvmeof pr #1238 to new cli Signed-off-by: Tomer Haskalovitch --- diff --git a/src/pybind/mgr/dashboard/controllers/nvmeof.py b/src/pybind/mgr/dashboard/controllers/nvmeof.py index 8c8987b769e..caf91ba4961 100644 --- a/src/pybind/mgr/dashboard/controllers/nvmeof.py +++ b/src/pybind/mgr/dashboard/controllers/nvmeof.py @@ -874,7 +874,9 @@ else: @NvmeofCLICommand("nvmeof connection list", model.ConnectionList) @convert_to_model(model.ConnectionList) @handle_nvmeof_error - def list(self, nqn: str, gw_group: Optional[str] = None, traddr: Optional[str] = None): + def list(self, nqn: Optional[str] = None, gw_group: Optional[str] = None, traddr: Optional[str] = None): + if not nqn: + nqn = '*' return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.list_connections( NVMeoFClient.pb2.list_connections_req(subsystem=nqn) ) diff --git a/src/pybind/mgr/dashboard/model/nvmeof.py b/src/pybind/mgr/dashboard/model/nvmeof.py index 00ef36280dc..dc4c8e2115d 100644 --- a/src/pybind/mgr/dashboard/model/nvmeof.py +++ b/src/pybind/mgr/dashboard/model/nvmeof.py @@ -94,6 +94,7 @@ class Connection(NamedTuple): connected: bool qpairs_count: int controller_id: int + subsystem: Optional[str] class ConnectionList(NamedTuple):