From: John Mulligan Date: Tue, 20 Feb 2024 15:09:50 +0000 (-0500) Subject: qa/tasks: fix VIPs log line X-Git-Tag: v19.1.0~82^2~31 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=4d823f4ba1567f005f8e6ab9aa65fcc0014c2bbd;p=ceph.git qa/tasks: fix VIPs log line While testing my previous patches were correct I noticed that the string here was logged exactly as written, and was thus pretty useless. This was probably meant to be an f-string. So make it one. Also get rid of the unnecessary map call, the list and IP address type can repr themselves just fine IMO. Signed-off-by: John Mulligan (cherry picked from commit 19e664fcdfeb62134db5d40210c40c63f7406a05) --- diff --git a/qa/tasks/vip.py b/qa/tasks/vip.py index 6554f12875381..d907fbbd23482 100644 --- a/qa/tasks/vip.py +++ b/qa/tasks/vip.py @@ -153,7 +153,7 @@ def task(ctx, config): if not ctx.vip: # do this only once (use the first remote we see), since we only need 1 # set of virtual IPs, regardless of how many remotes we have. - log.info("VIPs are {map(str, vips)}") + log.info(f"VIPs are {vips!r}") ctx.vip = { 'vnet': vnet, 'vips': vips,