From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Wed, 14 Aug 2019 09:10:12 +0000 (+0200)
Subject: common: replace shell module
X-Git-Tag: v5.0.0alpha1~166
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=4df92152c06496b7b9ce9558809f5488192499d3;p=ceph-ansible.git

common: replace shell module

there is no need to use `shell` in these tasks. Let's use `command`.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
---

diff --git a/roles/ceph-facts/tasks/facts.yml b/roles/ceph-facts/tasks/facts.yml
index 8cb8dab91..21c2d7ab3 100644
--- a/roles/ceph-facts/tasks/facts.yml
+++ b/roles/ceph-facts/tasks/facts.yml
@@ -106,7 +106,7 @@
     - not rolling_update | bool
   block:
   - name: generate cluster fsid
-    shell: "{{ discovered_interpreter_python }} -c 'import uuid; print(str(uuid.uuid4()))'"
+    command: "{{ discovered_interpreter_python }} -c 'import uuid; print(str(uuid.uuid4()))'"
     register: cluster_uuid
     delegate_to: "{{ groups[mon_group_name][0] }}"
     run_once: true
diff --git a/roles/ceph-mon/tasks/deploy_monitors.yml b/roles/ceph-mon/tasks/deploy_monitors.yml
index cf8346666..893ddde48 100644
--- a/roles/ceph-mon/tasks/deploy_monitors.yml
+++ b/roles/ceph-mon/tasks/deploy_monitors.yml
@@ -10,7 +10,7 @@
   when: ceph_current_status.fsid is defined
 
 - name: generate monitor initial keyring
-  shell: >
+  command: >
     {{ discovered_interpreter_python }} -c "import os ; import struct ;
     import time; import base64 ; key = os.urandom(16) ;
     header = struct.pack('<hiih',1,int(time.time()),0,len(key)) ;