From: Greg Farnum <gregf@hq.newdream.net>
Date: Tue, 8 Sep 2009 18:25:37 +0000 (-0700)
Subject: Hadoop: Refactor open to open optimistically and then check for errors
X-Git-Tag: v0.14~11
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4ea8d97d7def550af16bd832b89aa68836ec2d54;p=ceph.git

Hadoop: Refactor open to open optimistically and then check for errors
on the return code and cached data.
Also fix a bad return in CephFSInterface from the last commit.
---

diff --git a/src/client/hadoop/CephFSInterface.cc b/src/client/hadoop/CephFSInterface.cc
index 975d0c3e3fad..786d1cb905f7 100644
--- a/src/client/hadoop/CephFSInterface.cc
+++ b/src/client/hadoop/CephFSInterface.cc
@@ -315,7 +315,7 @@ JNIEXPORT jobjectArray JNICALL Java_org_apache_hadoop_fs_ceph_CephFileSystem_cep
   DIR *dirp;
   int r;
   r = ceph_opendir(c_path, &dirp);
-  if (r<0) return r;
+  if (r<0) return NULL;
   int buflen = 100; //good default?
   char *buf = new char[buflen];
   string *ent;
diff --git a/src/client/hadoop/ceph/CephFileSystem.java b/src/client/hadoop/ceph/CephFileSystem.java
index c45ae8dead56..a60fa5ff5052 100644
--- a/src/client/hadoop/ceph/CephFileSystem.java
+++ b/src/client/hadoop/ceph/CephFileSystem.java
@@ -50,6 +50,7 @@ import org.apache.hadoop.fs.FileStatus;
 public class CephFileSystem extends FileSystem {
 
   private static final int EEXIST = 17;
+  private static final int ENOENT = 2;
 
   private URI uri;
 
@@ -523,16 +524,20 @@ public class CephFileSystem extends FileSystem {
     debug("open:enter with path " + path);
     Path abs_path = makeAbsolute(path);
     
-    if (!exists(abs_path))
-      throw new IOException("open:  absolute path \""  + abs_path.toString()
-			    + "\" does not exist");
-    if(!isFile(abs_path))
-      throw new IOException("open:  absolute path \""  + abs_path.toString()
-			    + "\" is not a file");
-
     int fh = ceph_open_for_read(abs_path.toString());
-    if (fh < 0) {
-      throw new IOException("open: Failed to open file " + abs_path.toString());
+    if (fh < 0) { //uh-oh, something's bad!
+      if (fh == -ENOENT) //well that was a stupid open
+	throw new IOException("open:  absolute path \""  + abs_path.toString()
+			      + "\" does not exist");
+      else //hrm...the file exists but we can't open it :(
+	throw new IOException("open: Failed to open file " + abs_path.toString());
+    }
+
+    if(isDirectory(abs_path)) { //yes, it is possible to open Ceph directories
+      //but that doesn't mean you should in Hadoop!
+      ceph_close(fh);
+      throw new IOException("open:  absolute path \""  + abs_path.toString()
+			    + "\" is a directory!");
     }
     Stat lstat = new Stat();
     ceph_stat(abs_path.toString(), lstat);