From: John Mulligan Date: Sun, 5 Nov 2023 20:17:33 +0000 (-0500) Subject: cephadm: switch iscsi class to use daemon_to_container function X-Git-Tag: v19.0.0~24^2~8 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4f567ba2afe5d6227c514f66849487b99fc69c90;p=ceph.git cephadm: switch iscsi class to use daemon_to_container function Switch the iscsi daemon type class to call daemon_to_container instead of get_container in the class's container method. This breaks a dependency loop between the class and the get_container function hopefully enabling future clean ups and code moves. Signed-off-by: John Mulligan --- diff --git a/src/cephadm/cephadm.py b/src/cephadm/cephadm.py index fd213ffd6c85..7d91d90dccbd 100755 --- a/src/cephadm/cephadm.py +++ b/src/cephadm/cephadm.py @@ -1355,7 +1355,9 @@ done return tcmu_container def container(self, ctx: CephadmContext) -> CephContainer: - ctr = get_container(ctx, self.identity) + # So the container can modprobe iscsi_target_mod and have write perms + # to configfs we need to make this a privileged container. + ctr = daemon_to_container(ctx, self, privileged=True) return to_deployment_container(ctx, ctr) def config_and_keyring(