From: Patrick Donnelly <pdonnell@redhat.com>
Date: Mon, 25 Feb 2019 19:10:26 +0000 (-0800)
Subject: qa: update discontinous map test to use mds freezing
X-Git-Tag: v14.1.1~93^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=4fa4eda9ee9926268f10fcc295293185e95a0e46;p=ceph.git

qa: update discontinous map test to use mds freezing

and stop using standby_for_*.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
---

diff --git a/qa/tasks/cephfs/filesystem.py b/qa/tasks/cephfs/filesystem.py
index fa6d5edc0bf..a388c769f61 100644
--- a/qa/tasks/cephfs/filesystem.py
+++ b/qa/tasks/cephfs/filesystem.py
@@ -793,6 +793,9 @@ class Filesystem(MDSCluster):
         name = self.get_rank(rank=rank, status=status)['name']
         self.mds_signal(name, signal)
 
+    def rank_freeze(self, yes, rank=0):
+        self.mon_manager.raw_cluster_cmd("mds", "freeze", "{}:{}".format(self.id, rank), str(yes).lower())
+
     def rank_fail(self, rank=0):
         self.mon_manager.raw_cluster_cmd("mds", "fail", "{}:{}".format(self.id, rank))
 
diff --git a/qa/tasks/cephfs/test_failover.py b/qa/tasks/cephfs/test_failover.py
index c8999fa4580..63bfce6e8c2 100644
--- a/qa/tasks/cephfs/test_failover.py
+++ b/qa/tasks/cephfs/test_failover.py
@@ -313,47 +313,40 @@ class TestFailover(CephFSTestCase):
         That discontinuous mdsmap does not affect failover.
         See http://tracker.ceph.com/issues/24856.
         """
-        mds_ids = sorted(self.mds_cluster.mds_ids)
-        mds_a, mds_b = mds_ids[0:2]
-        # Assign mds to fixed ranks. To prevent standby mds from replacing frozen mds
-        rank = 0;
-        for mds_id in mds_ids:
-            self.set_conf("mds.{0}".format(mds_id), "mds_standby_for_rank", str(rank))
-            rank += 1
-        self.mds_cluster.mds_restart()
-        self.fs.wait_for_daemons()
-
         self.fs.set_max_mds(2)
-        self.fs.wait_for_state('up:active', rank=1)
+        status = self.fs.wait_for_daemons()
 
         self.mount_a.umount_wait()
 
         grace = float(self.fs.get_config("mds_beacon_grace", service_type="mon"))
         monc_timeout = float(self.fs.get_config("mon_client_ping_timeout", service_type="mds"))
 
-        # Freeze mds_a
-        self.mds_cluster.mds_signal(mds_a, signal.SIGSTOP)
+        mds_0 = self.fs.get_rank(rank=0, status=status)
+        self.fs.rank_freeze(True, rank=0) # prevent failover
+        self.fs.rank_signal(signal.SIGSTOP, rank=0, status=status)
         self.wait_until_true(
-            lambda: "laggy_since" in self.fs.status().get_mds(mds_a),
+            lambda: "laggy_since" in self.fs.get_rank(),
             timeout=grace * 2
         )
 
-        self.mds_cluster.mds_restart(mds_b)
+        self.fs.rank_fail(rank=1)
         self.fs.wait_for_state('up:resolve', rank=1, timeout=30)
 
-        # Make sure of mds_a's monitor connection gets reset
+        # Make sure of mds_0's monitor connection gets reset
         time.sleep(monc_timeout * 2)
 
-        # Unfreeze mds_a, it will get discontinuous mdsmap
-        self.mds_cluster.mds_signal(mds_a, signal.SIGCONT)
+        # Continue rank 0, it will get discontinuous mdsmap
+        self.fs.rank_signal(signal.SIGCONT, rank=0)
         self.wait_until_true(
-            lambda: "laggy_since" not in self.fs.status().get_mds(mds_a),
+            lambda: "laggy_since" not in self.fs.get_rank(rank=0),
             timeout=grace * 2
         )
 
         # mds.b will be stuck at 'reconnect' state if snapserver gets confused
         # by discontinuous mdsmap
         self.fs.wait_for_state('up:active', rank=1, timeout=30)
+        self.assertEqual(mds_0['gid'], self.fs.get_rank(rank=0)['gid'])
+        self.fs.rank_freeze(False, rank=0)
 
 class TestStandbyReplay(CephFSTestCase):
     MDSS_REQUIRED = 4