From: Kefu Chai <kchai@redhat.com>
Date: Thu, 7 Sep 2017 04:47:36 +0000 (+0800)
Subject: mon,option: set default value for mon_dns_srv_name
X-Git-Tag: v13.0.1~976^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=50207769f0c187cc8caf2bed3a1c94df409718e5;p=ceph.git

mon,option: set default value for mon_dns_srv_name

Fixes: http://tracker.ceph.com/issues/21204
Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/common/legacy_config_opts.h b/src/common/legacy_config_opts.h
index 1a846818ff0..ff7b7f4b7a7 100644
--- a/src/common/legacy_config_opts.h
+++ b/src/common/legacy_config_opts.h
@@ -22,7 +22,6 @@ OPTION(public_network, OPT_STR)
 OPTION(cluster_network, OPT_STR)
 OPTION(monmap, OPT_STR)
 OPTION(mon_host, OPT_STR)
-OPTION(mon_dns_srv_name, OPT_STR)
 OPTION(lockdep, OPT_BOOL)
 OPTION(lockdep_force_backtrace, OPT_BOOL) // always gather current backtrace at every lock
 OPTION(run_dir, OPT_STR)       // the "/var/run/ceph" dir, created on daemon startup
diff --git a/src/common/options.cc b/src/common/options.cc
index e6c678b3330..d3d60996775 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -201,6 +201,7 @@ std::vector<Option> get_global_options() {
     .add_service("common"),
 
     Option("mon_dns_srv_name", Option::TYPE_STR, Option::LEVEL_ADVANCED)
+    .set_default("ceph-mon")
     .set_description("name of DNS SRV record to check for monitor addresses")
     .add_service("common")
     .add_tag("network")
diff --git a/src/mon/MonMap.cc b/src/mon/MonMap.cc
index 218df9aa843..67381bd430a 100644
--- a/src/mon/MonMap.cc
+++ b/src/mon/MonMap.cc
@@ -536,7 +536,7 @@ int MonMap::build_initial(CephContext *cct, ostream& errout)
 
   if (size() == 0) {
     // no info found from conf options lets try use DNS SRV records
-    string srv_name = conf->mon_dns_srv_name;
+    string srv_name = conf->get_val<std::string>("mon_dns_srv_name");
     string domain;
     // check if domain is also provided and extract it from srv_name
     size_t idx = srv_name.find("_");