From: xie xingguo Date: Wed, 5 Dec 2018 08:36:18 +0000 (+0800) Subject: msg/async: truly use first addr if multiple incoming addrs provided X-Git-Tag: v14.1.0~604^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=50d8c8a3cce3bfbfc9be5acfa60bda165d59e2bc;p=ceph.git msg/async: truly use first addr if multiple incoming addrs provided For incoming IPv4 and IPv6 dual stack support, there might be multiple addresses provided in entity's addrvec. The comment says we'll just pick whichever is listed first for now to accept, whereas the implementation does quite the opposite. Signed-off-by: xie xingguo --- diff --git a/src/msg/async/AsyncMessenger.cc b/src/msg/async/AsyncMessenger.cc index 959e76f77787..d2737608c708 100644 --- a/src/msg/async/AsyncMessenger.cc +++ b/src/msg/async/AsyncMessenger.cc @@ -578,6 +578,7 @@ AsyncConnectionRef AsyncMessenger::create_connect( // FIXME: for ipv4 vs ipv6, check whether local host can handle ipv6 before // trying it? for now, just pick whichever is listed first. target = a; + break; } // create connection