From: Sage Weil <sage@inktank.com>
Date: Tue, 9 Jul 2013 04:33:22 +0000 (-0700)
Subject: mon/PaxosService: uninline should_trim()
X-Git-Tag: v0.67-rc1~134^2~12
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=50ffe324e3af1249c8ebf5b928acd5bc43bb0be9;p=ceph.git

mon/PaxosService: uninline should_trim()

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/mon/PaxosService.cc b/src/mon/PaxosService.cc
index 9330c56e7afd..dca64360348a 100644
--- a/src/mon/PaxosService.cc
+++ b/src/mon/PaxosService.cc
@@ -326,6 +326,20 @@ void PaxosService::shutdown()
   finish_contexts(g_ceph_context, waiting_for_finished_proposal, -EAGAIN);
 }
 
+bool PaxosService::should_trim()
+{
+  if (!service_should_trim())
+    return false;
+
+  if (g_conf->paxos_service_trim_min > 0) {
+    version_t trim_to = get_trim_to();
+    version_t first = get_first_committed();
+    if ((trim_to > 0) && trim_to > first)
+      return ((trim_to - first) >= (version_t)g_conf->paxos_service_trim_min);
+   }
+  return true;
+}
+
 void PaxosService::trim(MonitorDBStore::Transaction *t,
 			version_t from, version_t to)
 {
diff --git a/src/mon/PaxosService.h b/src/mon/PaxosService.h
index 3e5c69fb22fe..18d95307ef42 100644
--- a/src/mon/PaxosService.h
+++ b/src/mon/PaxosService.h
@@ -682,23 +682,10 @@ public:
   virtual void encode_trim_extra(MonitorDBStore::Transaction *tx, version_t first) {}
 
   /**
-   *
+   * decide whether we should trim service states
    */
-  virtual bool should_trim() {
-    bool want_trim = service_should_trim();
-
-    if (!want_trim)
-      return false;
-
-    if (g_conf->paxos_service_trim_min > 0) {
-      version_t trim_to = get_trim_to();
-      version_t first = get_first_committed();
+  bool should_trim();
 
-      if ((trim_to > 0) && trim_to > first)
-        return ((trim_to - first) >= (version_t)g_conf->paxos_service_trim_min);
-    }
-    return true;
-  }
   /**
    * Check if we should trim.
    *