From: Brad Hubbard <bhubbard@redhat.com>
Date: Wed, 3 Jan 2018 03:06:26 +0000 (+1000)
Subject: mds: Remove redundant null pointer check
X-Git-Tag: wip-pdonnell-testing-20180317.202121~706^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=5132a1ce3845bd217fe4e35d33d9ffa3ac908c0f;p=ceph-ci.git

mds: Remove redundant null pointer check

Resolves Coverity CID 1426746

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
---

diff --git a/src/mds/MDBalancer.cc b/src/mds/MDBalancer.cc
index 14b930c8a6e..4801f8f5abf 100644
--- a/src/mds/MDBalancer.cc
+++ b/src/mds/MDBalancer.cc
@@ -1269,11 +1269,9 @@ int MDBalancer::dump_loads(Formatter *f)
     CDir *dir = dfs.front();
     dfs.pop_front();
 
-    if (f) {
-      f->open_object_section("dir");
-      dir->dump_load(f, now, decayrate);
-      f->close_section();
-    }
+    f->open_object_section("dir");
+    dir->dump_load(f, now, decayrate);
+    f->close_section();
 
     for (CDir::map_t::iterator it = dir->begin(); it != dir->end(); ++it) {
       CInode *in = it->second->get_linkage()->get_inode();