From: Gil Bregman Date: Mon, 13 Apr 2026 21:41:25 +0000 (+0300) Subject: mgr/dashboard: Add port and secure-listeners to subsystem add NVMeoF CLI command X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=513ffb629f773727c95b9efa9ae397b8194ffcfe;p=ceph.git mgr/dashboard: Add port and secure-listeners to subsystem add NVMeoF CLI command Fixes: https://tracker.ceph.com/issues/75998 Signed-off-by: Gil Bregman (cherry picked from commit 624adc09431dc2fdfa617940161f188c0831bf97) Conflicts: src/pybind/mgr/dashboard/controllers/nvmeof.py Resolve conflict to use "traddr" instead of "server_address" in NVMeoFSubsystem().create() parameters. Main branch renamed the param ("traddr") to "server_address". Tentacle --- diff --git a/src/pybind/mgr/dashboard/controllers/nvmeof.py b/src/pybind/mgr/dashboard/controllers/nvmeof.py index 501eaf06d31..e1504d17d85 100644 --- a/src/pybind/mgr/dashboard/controllers/nvmeof.py +++ b/src/pybind/mgr/dashboard/controllers/nvmeof.py @@ -238,6 +238,10 @@ else: "network_mask": Param([str], "Network mask to automatically create listeners", True, None), + "port": Param(int, "Port to use for the created listeners", True, None), + "secure_listeners": Param(bool, + "Make all the auto-listeners for this subsystem secure", + True, False), }, ) @convert_to_model(model.SubsystemStatus) @@ -246,13 +250,15 @@ else: max_namespaces: Optional[int] = None, no_group_append: Optional[bool] = False, serial_number: Optional[str] = None, dhchap_key: Optional[str] = None, gw_group: Optional[str] = None, traddr: Optional[str] = None, - network_mask: Optional[List[str]] = None): + network_mask: Optional[List[str]] = None, + port: Optional[int] = None, secure_listeners: Optional[bool] = False): return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.create_subsystem( NVMeoFClient.pb2.create_subsystem_req( subsystem_nqn=nqn, serial_number=serial_number, max_namespaces=max_namespaces, enable_ha=enable_ha, no_group_append=no_group_append, dhchap_key=dhchap_key, network_mask=network_mask, + port=port, secure_listeners=secure_listeners ) ) diff --git a/src/pybind/mgr/dashboard/openapi.yaml b/src/pybind/mgr/dashboard/openapi.yaml index e783fcfacff..e3b8ffa396c 100644 --- a/src/pybind/mgr/dashboard/openapi.yaml +++ b/src/pybind/mgr/dashboard/openapi.yaml @@ -9760,6 +9760,13 @@ paths: nqn: description: NVMeoF subsystem NQN type: string + port: + description: Port to use for the created listeners + type: integer + secure_listeners: + default: false + description: Make all the auto-listeners for this subsystem secure + type: boolean serial_number: description: Subsystem serial number type: string