From: Ivo Almeida <ialmeida@redhat.com>
Date: Fri, 31 May 2024 09:45:25 +0000 (+0100)
Subject: fixed navigation tests
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=516b4a067885fa10fa2011cd7c812246d83c03a7;p=ceph.git

fixed navigation tests
---

diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/navigation.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/navigation.e2e-spec.ts
index 9c0383dfb922b..1625dab4fb55e 100644
--- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/navigation.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/navigation.e2e-spec.ts
@@ -9,12 +9,12 @@ describe('Shared pages', () => {
   });
 
   it('should display the vertical menu by default', () => {
-    shared.getVerticalMenu().should('not.have.class', 'cds--side-nav__item--active');
+    shared.getVerticalMenu().should('not.have.class', 'active');
   });
 
   it('should hide the vertical menu', () => {
     shared.getMenuToggler().click();
-    shared.getVerticalMenu().should('have.class', 'cds--side-nav__item--active');
+    shared.getVerticalMenu().should('have.class', 'active');
   });
 
   it('should navigate to the correct page', () => {
diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/navigation.po.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/navigation.po.ts
index f2eefd826d8a8..89c4c7394d9ff 100644
--- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/navigation.po.ts
+++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/navigation.po.ts
@@ -75,7 +75,7 @@ export class NavigationPageHelper extends PageHelper {
   }
 
   getMenuToggler() {
-    return cy.get('[aria-label="toggle sidebar visibility"]');
+    return cy.get('[data-testid="main-menu-toggler"]');
   }
 
   checkNavigations(navs: any) {
@@ -85,7 +85,7 @@ export class NavigationPageHelper extends PageHelper {
     cy.intercept('/ui-api/block/rbd/status', { fixture: 'block-rbd-status.json' });
 
     navs.forEach((nav: any) => {
-      cy.get('.simplebar-content li.nav-item a').each(($link) => {
+      cy.get('cds-sidenav-item').each(($link) => {
         if ($link.text().trim() === nav.menu.trim()) {
           cy.wrap($link).click();
         }
@@ -100,9 +100,9 @@ export class NavigationPageHelper extends PageHelper {
 
   checkNavSubMenu(menu: any, submenu: any) {
     submenu.forEach((nav: any) => {
-      cy.get('.simplebar-content li.nav-item a').each(($link) => {
+      cy.get('cds-sidenav-item').each(($link) => {
         if ($link.text().trim() === menu.trim()) {
-          cy.contains(`ul.list-unstyled li a`, nav.menu).click();
+          cy.contains(`cds-sidenav-menu`, nav.menu).click();
         }
       });
     });
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
index 2d9be03b2c03e..3692e23967653 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
@@ -13,6 +13,7 @@
             class="cd-navbar-top"
             [brand]="brandTemplate">
   <cds-hamburger [active]="showMenuSidebar"
+                 data-testid="main-menu-toggler"
                  (selected)="showMenuSidebar = !showMenuSidebar"></cds-hamburger>
   <cds-header-global>
     <cds-header-navigation>