From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Mon, 20 Feb 2017 14:56:40 +0000 (+0100)
Subject: test_ipaddr.cc: fix UNINIT issues around sockaddr_in struct
X-Git-Tag: v12.0.2~116^2~14
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5202b9f95ff7574406f39dff3d697209c282b94a;p=ceph.git

test_ipaddr.cc: fix UNINIT issues around sockaddr_in struct

Fix for:

CID 1396088 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396090 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396091 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396092 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396096 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396097 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396099 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396101 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396103 (#1 of 1): Uninitialized scalar variable (UNINIT)
CID 1396104 (#1 of 1): Uninitialized scalar variable (UNINIT)

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/test/test_ipaddr.cc b/src/test/test_ipaddr.cc
index 716094d80d8..ab43407ec5e 100644
--- a/src/test/test_ipaddr.cc
+++ b/src/test/test_ipaddr.cc
@@ -34,6 +34,8 @@ TEST(CommonIPAddr, TestNotFound)
   struct sockaddr_in net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -58,6 +60,8 @@ TEST(CommonIPAddr, TestV4_Simple)
   struct sockaddr_in net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -82,6 +86,8 @@ TEST(CommonIPAddr, TestV4_Prefix25)
   struct sockaddr_in net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -106,6 +112,8 @@ TEST(CommonIPAddr, TestV4_Prefix16)
   struct sockaddr_in net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -129,6 +137,8 @@ TEST(CommonIPAddr, TestV4_PrefixTooLong)
   struct sockaddr_in net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+
   one.ifa_next = NULL;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -148,6 +158,8 @@ TEST(CommonIPAddr, TestV4_PrefixZero)
   struct sockaddr_in net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -172,6 +184,8 @@ TEST(CommonIPAddr, TestV6_Simple)
   struct sockaddr_in6 net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+  
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -196,6 +210,8 @@ TEST(CommonIPAddr, TestV6_Prefix57)
   struct sockaddr_in6 net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+
   one.ifa_next = &two;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;
@@ -219,6 +235,8 @@ TEST(CommonIPAddr, TestV6_PrefixTooLong)
   struct sockaddr_in6 net;
   const struct sockaddr *result;
 
+  memset(&net, '0', sizeof(net));
+
   one.ifa_next = NULL;
   one.ifa_addr = (struct sockaddr*)&a_one;
   one.ifa_name = eth0;